- Mar 12, 2019
-
-
chrisgarrity authored
Account for the addition of locale prop expected in mapStateToProps. Note: if/when the telemetry code gets moved into its own hoc, the prop should get removed, and the test should get updated as well.
-
- Mar 11, 2019
-
-
Paul Kaplan authored
A few modifications were made while making this test: - Change the "defaultMin/Max" to just be called "min/max", and pass the state through to make the inputs a controlled component. It is best to make form elements controlled since it makes it more clear how data flows. - Force the passed in data to always be of type `number`, and transform it in the constructor to always be of type `string`, and change the onOk to transform it back to a number. With inputs, it is best to be very explicit about data types, and make it clear where you are using strings and where you are using numbers. - Do not reset the state to `0` when the field is blank, that makes typing into it very hard (only applies after making it a controlled field) - Use consistent booleans. Since the VM uses `isDiscrete`, change it so we do not use any opposite flags (like `decimal`) for clarity. Writing tests for this really helped me understand the behavior. If you read through the test descriptions and see anything you did not intend, let me know.
-
Paul Kaplan authored
-
- Feb 15, 2019
-
-
Paul Kaplan authored
-
Paul Kaplan authored
-
- Feb 13, 2019
-
-
Paul Kaplan authored
-
- Feb 12, 2019
-
-
picklesrus authored
-
Paul Kaplan authored
-
Paul Kaplan authored
-
Paul Kaplan authored
-
- Feb 11, 2019
-
-
Paul Kaplan authored
-
Paul Kaplan authored
-
- Feb 08, 2019
-
-
Paul Kaplan authored
-
Paul Kaplan authored
-
Paul Kaplan authored
-
- Feb 06, 2019
-
-
Paul Kaplan authored
-
Paul Kaplan authored
Including sprites, backdrops, costumes and sounds inputs
-
Paul Kaplan authored
-
Paul Kaplan authored
-
Paul Kaplan authored
I needed to update the player css because the editor side wasn't large enough to be useable.
-
- Feb 05, 2019
-
-
Karishma Chadha authored
-
- Feb 04, 2019
-
-
Luke Schlangen authored
-
Paul Kaplan authored
-
Paul Kaplan authored
-
- Feb 03, 2019
-
-
Luke Schlangen authored
-
- Feb 01, 2019
-
-
Nikhil Jha authored
-
Nikhil Jha authored
-
- Jan 30, 2019
-
-
Karishma Chadha authored
Update project changes test to test a project change that should actually emit a change event. Clicking on blocks should not emit a project changed event.
-
Paul Kaplan authored
I know we will want to change this eventually, so I added comments about that. But the next commit originally contained an inadvertent change to this functionality, so I wanted to add an integration test so that when we do change it, we
-
Paul Kaplan authored
It looks like an "test.only" was left in on one of these tests by mistake.
-
- Jan 29, 2019
-
-
Nikhil Jha authored
-
- Jan 26, 2019
-
-
Nikhil Jha authored
-
Nikhil Jha authored
-
- Jan 24, 2019
-
-
Nikhil Jha authored
-
- Jan 23, 2019
-
-
picklesrus authored
-
Paul Kaplan authored
-
Paul Kaplan authored
Adds unit tests for this HOC.
-
- Jan 22, 2019
-
-
Paul Kaplan authored
-
Paul Kaplan authored
Forcing the playhead onto its own painting layer removes an expensive composite with the waveform. Animate using transforms instead of left prevents layouts of the rest of the page while playing a sound.
-
- Jan 17, 2019
-
-
Paul Kaplan authored
-