Skip to content
Snippets Groups Projects
  1. Jan 30, 2020
  2. Jan 28, 2020
    • Ben Wheeler's avatar
      continuing sb file uploader refactor into hoc · f2291d96
      Ben Wheeler authored
      draft of refactor to make custom confirm modal work for upload; need to further edit sb-file-uploader
      
      Add support for custom confirm modal to sb-file-uploader
      
      Show custom confirm modal when confirming project upload
      
      got custom upload refactor of file upload working, and tested failure case
      
      cleaned up debug code, make project file upload work
      
      simplified logic around canceling file upload
      
      removed old sb-file-uploader.jsx; fixed linter errors
      
      reverted two components to use old strings, not shared
      
      (can do that refactor another time)
      
      removed unnecessary confirm container
      
      removed stray comment
      
      moved, updated sb file uploader tests, related project state tests
      
      removed custom modal, to reduce scope of changes
      
      sb file uploader test uses intl
      f2291d96
  3. Jan 27, 2020
  4. Jan 06, 2020
  5. May 07, 2019
  6. Apr 17, 2019
  7. Mar 18, 2019
  8. Feb 13, 2019
  9. Feb 04, 2019
  10. Feb 03, 2019
  11. Jan 29, 2019
  12. Jan 23, 2019
    • Paul Kaplan's avatar
      Remove the redux throttle for targets update. · c75e2acf
      Paul Kaplan authored
      This fixes the root cause of #2858, which is caused because we are rendering the sound editor based on the GUI editing target data, but retrieving the sound based on the vms editing target data. The throttle of the redux action was causing those to get out of sync while a project was running.
      
      The throttle is not needed because the vm runtime already batches those updates at 30 fps. The updates that come from top-level actions like switching sprites go out immediately.
      
      This is also a minor performance boost, because there was a few ms being spent in setting and checking timers that were not needed.
      c75e2acf
  13. Jan 10, 2019
  14. Dec 20, 2018
  15. Dec 18, 2018
  16. Dec 10, 2018
  17. Dec 06, 2018
  18. Dec 05, 2018
    • chrisgarrity's avatar
      rename isEmbedded · ad328c06
      chrisgarrity authored
      Liked @paulkaplan’s suggestion that the property get renamed `showBranding` as we use ‘embedded’ in multiple ways that would get confusing.
      
      The embedded project view is ‘playerOnly’, ‘fullscreen’ and ‘showBranding’.
      ad328c06
  19. Dec 04, 2018
  20. Nov 29, 2018
  21. Nov 28, 2018
    • Paul Kaplan's avatar
      Add download and retry saving to saving error alert. · bd6c6599
      Paul Kaplan authored
      I do not like how the alert component is hyper specialized for two distinct use cases. It would be much better to refactor the alerts so that the alerter can just fill the alert with whatever they want. But I do not feel comfortable making that refactor because I know ben and evelyn have gone back and forth about these alerts.
      bd6c6599
    • Ray Schamp's avatar
      Track "project changed" state in Redux · 09592425
      Ray Schamp authored
      Listen to the new project changed event from the VM and keep track of the state in Redux.  Update it as appropriate.
      
      Known issue is that the project is marked as "changed" immediately after it's loaded. This is due to asynchronous event emitting while the project data is loaded, and needs an update to the VM to fix.
      09592425
  22. Nov 27, 2018
Loading