Skip to content
Snippets Groups Projects
Commit c75e2acf authored by Paul Kaplan's avatar Paul Kaplan
Browse files

Remove the redux throttle for targets update.

This fixes the root cause of #2858, which is caused because we are rendering the sound editor based on the GUI editing target data, but retrieving the sound based on the vms editing target data. The throttle of the redux action was causing those to get out of sync while a project was running.

The throttle is not needed because the vm runtime already batches those updates at 30 fps. The updates that come from top-level actions like switching sprites go out immediately.

This is also a minor performance boost, because there was a few ms being spent in setting and checking timers that were not needed.
parent 9a4ef280
No related branches found
Tags 0.1.0-prerelease.20190715194054
No related merge requests found
......@@ -39,10 +39,7 @@ const updateTargets = function (targetList, editingTarget) {
return {
type: UPDATE_TARGET_LIST,
targets: targetList,
editingTarget: editingTarget,
meta: {
throttle: 30
}
editingTarget: editingTarget
};
};
const highlightTarget = function (targetId) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment