It also avoids repeating the costly object spread, which becomes a problem for projects with a lot of sprites

The fontInliner from the scratch-svg-renderer was changed recently to work entirely on strings, so we can use that instead of parsing/loading/possibly drawing/stringifying the entire SVG. 

This does not address the size-1 cache issue where the cache is invalidated any time there is more than 1 sprite. But that can be handled later.

Using the 4x CPU slowdown in chrome dev tools, on a simple costume that just has a single text element the getCostumeUrl time goes from 10ms to 1ms, very important for updating in a timely way.

Adds unit tests for this HOC.

Use PureComponent instead since it is a simple shouldComponentUpdate check now.

This fixes the root cause of #2858, which is caused because we are rendering the sound editor based on the GUI editing target data, but retrieving the sound based on the vms editing target data. The throttle of the redux action was causing those to get out of sync while a project was running.

The throttle is not needed because the vm runtime already batches those updates at 30 fps. The updates that come from top-level actions like switching sprites go out immediately.

This is also a minor performance boost, because there was a few ms being spent in setting and checking timers that were not needed.

Forcing the playhead onto its own painting layer removes an expensive composite with the waveform. Animate using transforms instead of left prevents layouts of the rest of the page while playing a sound.

The waveform component was being re-rendered while the playhead changed, which is a costly operation because it has to calculate the full svg path data string.

Also use white as the background since it gives the same impact and will not look bad if the filter isn't applied or takes a while to be applied

We were emitting drops when getMouseOverIndex was null, which could happen either when the drop is outside the container, or there were zero boxes to check for ordering. Treat these two cases separately, and continue to not emit drops when outside the container.

This reverts commit 97f8eb63, reversing
changes made to 2e017f06.

See #4382 for more info about why, and what we need to follow up on it

The previous change that made the images laid out using absolute meant that the close button was layered below the sprite image, making it now clickable

On some projects, the sprite image changes frequently, which can cause global layouts and paints if we arent careful. Use the same absolute positioning strategy from the sprite library animations to contain layouts to the sprite image itself

There was a useability issue discovered in testing where trying to trim a sound to be of zero length would fail, but just leave the trimmers active. Clear them out, since the trim is invalid

This is used because the sortable drop is also used for general dropping as well as sorting drop, so you need to be able to drop into a sortable list that does not contain any items.

Make the corresponding reorder code be more careful to check if there is a newIndex.

On slow machines it was possible to double click record before the chunk of samples had been processed, causing zero-length audio buffers

Discovered this while trying to pass other props to the stage wrapper, we were not passing isRTL to the stage wrapper, causing ask/answer bubble to not display the right direction.