Skip to content
Snippets Groups Projects
  1. Mar 11, 2019
    • Paul Kaplan's avatar
      Add container test for slider prompt · 127e1a96
      Paul Kaplan authored
      A few modifications were made while making this test:
      - Change the "defaultMin/Max" to just be called "min/max", and pass the state through to make the inputs a controlled component. It is best to make form elements controlled since it makes it more clear how data flows.
      - Force the passed in data to always be of type `number`, and transform it in the constructor to always be of type `string`, and change the onOk to transform it back to a number. With inputs, it is best to be very explicit about data types, and make it clear where you are using strings and where you are using numbers.
      - Do not reset the state to `0` when the field is blank, that makes typing into it very hard (only applies after making it a controlled field)
      - Use consistent booleans. Since the VM uses `isDiscrete`, change it so we do not use any opposite flags (like `decimal`) for clarity.
      
      Writing tests for this really helped me understand the behavior. If you read through the test descriptions and see anything you did not intend, let me know.
      127e1a96
    • Paul Kaplan's avatar
      Add a selenium test for slider range · 1e532745
      Paul Kaplan authored
      1e532745
  2. Feb 15, 2019
  3. Feb 13, 2019
  4. Feb 12, 2019
  5. Feb 11, 2019
  6. Feb 08, 2019
  7. Feb 06, 2019
  8. Feb 05, 2019
  9. Feb 04, 2019
  10. Feb 03, 2019
  11. Feb 01, 2019
  12. Jan 30, 2019
  13. Jan 29, 2019
  14. Jan 26, 2019
  15. Jan 24, 2019
  16. Jan 23, 2019
  17. Jan 22, 2019
  18. Jan 17, 2019
Loading