Skip to content
Snippets Groups Projects
  1. Jan 09, 2020
  2. Oct 17, 2019
  3. Aug 21, 2019
  4. Aug 08, 2019
  5. Aug 02, 2019
  6. Aug 01, 2019
    • rschamp's avatar
      Add Jest-specific linting rules · 3c6bfe06
      rschamp authored
      Adding this caught a couple of important things:
      - The sound integration tests have a `.only` in them
      - The project-saver-hoc tests had two tests with the same description, causing possible confusion if that test broke
      3c6bfe06
  7. Jul 31, 2019
  8. Jul 30, 2019
  9. Jul 29, 2019
  10. Jul 26, 2019
    • Chris Garrity's avatar
      fix focus styling · cd7b5d93
      Chris Garrity authored
      Don’t use default focus style it’s ugly.
      
      Don’t allow the image to be dragged.
      cd7b5d93
  11. Jul 25, 2019
  12. Jul 24, 2019
  13. Jul 23, 2019
  14. Jul 22, 2019
  15. Jul 15, 2019
  16. Jul 09, 2019
  17. Jun 20, 2019
  18. Jun 19, 2019
  19. Jun 18, 2019
  20. Jun 05, 2019
  21. Jun 03, 2019
  22. May 23, 2019
  23. May 01, 2019
  24. Apr 19, 2019
  25. Apr 17, 2019
  26. Mar 12, 2019
    • chrisgarrity's avatar
      Fix mock store for project-saver-hoc test · 3e33c10b
      chrisgarrity authored
      Account for the addition of locale prop expected in mapStateToProps.
      Note: if/when the telemetry code gets moved into its own hoc, the prop should get removed, and the test should get updated as well.
      3e33c10b
  27. Mar 11, 2019
    • Paul Kaplan's avatar
      Add container test for slider prompt · 127e1a96
      Paul Kaplan authored
      A few modifications were made while making this test:
      - Change the "defaultMin/Max" to just be called "min/max", and pass the state through to make the inputs a controlled component. It is best to make form elements controlled since it makes it more clear how data flows.
      - Force the passed in data to always be of type `number`, and transform it in the constructor to always be of type `string`, and change the onOk to transform it back to a number. With inputs, it is best to be very explicit about data types, and make it clear where you are using strings and where you are using numbers.
      - Do not reset the state to `0` when the field is blank, that makes typing into it very hard (only applies after making it a controlled field)
      - Use consistent booleans. Since the VM uses `isDiscrete`, change it so we do not use any opposite flags (like `decimal`) for clarity.
      
      Writing tests for this really helped me understand the behavior. If you read through the test descriptions and see anything you did not intend, let me know.
      127e1a96
  28. Feb 15, 2019
  29. Feb 13, 2019
  30. Feb 12, 2019
  31. Feb 11, 2019
Loading