Skip to content
Snippets Groups Projects
  1. Jul 22, 2019
  2. Jun 20, 2019
  3. Jun 19, 2019
  4. Jun 18, 2019
  5. Jun 05, 2019
  6. Jun 03, 2019
  7. May 23, 2019
  8. May 01, 2019
  9. Apr 19, 2019
  10. Apr 17, 2019
  11. Mar 12, 2019
    • chrisgarrity's avatar
      Fix mock store for project-saver-hoc test · 3e33c10b
      chrisgarrity authored
      Account for the addition of locale prop expected in mapStateToProps.
      Note: if/when the telemetry code gets moved into its own hoc, the prop should get removed, and the test should get updated as well.
      3e33c10b
  12. Mar 11, 2019
    • Paul Kaplan's avatar
      Add container test for slider prompt · 127e1a96
      Paul Kaplan authored
      A few modifications were made while making this test:
      - Change the "defaultMin/Max" to just be called "min/max", and pass the state through to make the inputs a controlled component. It is best to make form elements controlled since it makes it more clear how data flows.
      - Force the passed in data to always be of type `number`, and transform it in the constructor to always be of type `string`, and change the onOk to transform it back to a number. With inputs, it is best to be very explicit about data types, and make it clear where you are using strings and where you are using numbers.
      - Do not reset the state to `0` when the field is blank, that makes typing into it very hard (only applies after making it a controlled field)
      - Use consistent booleans. Since the VM uses `isDiscrete`, change it so we do not use any opposite flags (like `decimal`) for clarity.
      
      Writing tests for this really helped me understand the behavior. If you read through the test descriptions and see anything you did not intend, let me know.
      127e1a96
  13. Feb 15, 2019
  14. Feb 13, 2019
  15. Feb 12, 2019
  16. Feb 11, 2019
  17. Feb 04, 2019
  18. Feb 03, 2019
  19. Jan 23, 2019
  20. Jan 22, 2019
  21. Jan 17, 2019
  22. Jan 16, 2019
  23. Dec 26, 2018
  24. Dec 18, 2018
  25. Dec 06, 2018
  26. Dec 05, 2018
  27. Dec 04, 2018
  28. Dec 03, 2018
  29. Nov 29, 2018
  30. Nov 28, 2018
Loading