- Mar 11, 2019
-
-
Paul Kaplan authored
-
Paul Kaplan authored
-
Paul Kaplan authored
A few modifications were made while making this test: - Change the "defaultMin/Max" to just be called "min/max", and pass the state through to make the inputs a controlled component. It is best to make form elements controlled since it makes it more clear how data flows. - Force the passed in data to always be of type `number`, and transform it in the constructor to always be of type `string`, and change the onOk to transform it back to a number. With inputs, it is best to be very explicit about data types, and make it clear where you are using strings and where you are using numbers. - Do not reset the state to `0` when the field is blank, that makes typing into it very hard (only applies after making it a controlled field) - Use consistent booleans. Since the VM uses `isDiscrete`, change it so we do not use any opposite flags (like `decimal`) for clarity. Writing tests for this really helped me understand the behavior. If you read through the test descriptions and see anything you did not intend, let me know.
-
Paul Kaplan authored
-
- Mar 08, 2019
-
-
apple502j authored
-
- Feb 27, 2019
-
-
apple502j authored
-
- Feb 16, 2019
-
-
apple502j authored
-
- Feb 14, 2019
-
-
Paul Kaplan authored
Because the `onFrame` callback could do async work, it was possible for onDone to try to submit the costumes before the onFrame had produced any. This was subject to browsers different timing treatments of setTimeout vs. promise resolution. This makes the gif-decoder use the same style of progress API as the file uploader
-
- Feb 13, 2019
-
-
Paul Kaplan authored
-
Paul Kaplan authored
-
Paul Kaplan authored
-
Paul Kaplan authored
-
Paul Kaplan authored
-
- Feb 11, 2019
-
-
Paul Kaplan authored
Selenium loads the playground using the file:// protocol, where history.replaceState throws an error
-
Paul Kaplan authored
This only shows when you are on a project that is SHOWING_WITHOUT_ID and has changes. This is only the case when logged out, or in the desktop editor.
-
Paul Kaplan authored
-
Paul Kaplan authored
-
Paul Kaplan authored
-
- Feb 08, 2019
-
-
Paul Kaplan authored
-
Paul Kaplan authored
-
Paul Kaplan authored
-
Paul Kaplan authored
-
Paul Kaplan authored
-
Paul Kaplan authored
-
Paul Kaplan authored
-
- Feb 07, 2019
-
-
Paul Kaplan authored
-
Paul Kaplan authored
This was already being used for sb3s and sprite3s, but the code was repeated in different places. Make a single helper that downloads blobs, and make all download paths use it.
-
- Feb 06, 2019
-
-
Michael "Z" Goddard authored
-
Paul Kaplan authored
-
Paul Kaplan authored
-
Florrie authored
-
Michael "Z" Goddard authored
-
Paul Kaplan authored
I needed to update the player css because the editor side wasn't large enough to be useable.
-
- Feb 05, 2019
-
-
Paul Kaplan authored
We can't rely on refreshWorkspace always causing a toolbox update, so make sure to update the toolbox manually if it is needed.
-
Xu Jing authored
-
Karishma Chadha authored
-
- Feb 04, 2019
-
-
Florrie authored
-
chrisgarrity authored
Override the z-index for the blocks drag layer. At 1000, it will be over everything in the gui other than the navbar itself (monitors on the stage, tutorials, alerts, dropdown menus, etc.)
-
Luke Schlangen authored
-
Paul Kaplan authored
This fixes a problem where having a non-default locale set during the initial load would display the blocks in the default toolbox in the wrong language, because the toolbox recycling toggle in setLocale does not work on initial load because there is no editing target to refresh.
-