Skip to content
Snippets Groups Projects
  1. Mar 18, 2019
  2. Mar 14, 2019
  3. Mar 12, 2019
  4. Mar 11, 2019
    • Paul Kaplan's avatar
      Remove analytics library imports · 51f9aafe
      Paul Kaplan authored
      51f9aafe
    • Paul Kaplan's avatar
      Remove some of the high-volume analytics events · e746b98d
      Paul Kaplan authored
      Too much traffic, not enough value. Leaving stuff having to do with tips library/tutorial card navigation as well as hardware extension connectivity, as those help us find issues with Scratch.
      e746b98d
    • Paul Kaplan's avatar
      Remove focus selecting in slider prompt · f72d0b59
      Paul Kaplan authored
      It is not reliably selecting the input and is making it hard to type into.
      f72d0b59
    • Paul Kaplan's avatar
      Fix more prop ordering for linter · abf49b31
      Paul Kaplan authored
      abf49b31
    • Paul Kaplan's avatar
      Fix prop ordering for linter · a627552c
      Paul Kaplan authored
      a627552c
    • Paul Kaplan's avatar
      Add container test for slider prompt · 127e1a96
      Paul Kaplan authored
      A few modifications were made while making this test:
      - Change the "defaultMin/Max" to just be called "min/max", and pass the state through to make the inputs a controlled component. It is best to make form elements controlled since it makes it more clear how data flows.
      - Force the passed in data to always be of type `number`, and transform it in the constructor to always be of type `string`, and change the onOk to transform it back to a number. With inputs, it is best to be very explicit about data types, and make it clear where you are using strings and where you are using numbers.
      - Do not reset the state to `0` when the field is blank, that makes typing into it very hard (only applies after making it a controlled field)
      - Use consistent booleans. Since the VM uses `isDiscrete`, change it so we do not use any opposite flags (like `decimal`) for clarity.
      
      Writing tests for this really helped me understand the behavior. If you read through the test descriptions and see anything you did not intend, let me know.
      127e1a96
    • Paul Kaplan's avatar
      Add default values for non-required props · 438e0f9c
      Paul Kaplan authored
      438e0f9c
  5. Mar 08, 2019
  6. Mar 07, 2019
  7. Mar 06, 2019
  8. Mar 05, 2019
  9. Mar 04, 2019
  10. Feb 28, 2019
    • chrisgarrity's avatar
      Refactor step and step image naming conventions · 686dbb52
      chrisgarrity authored
      Step Ids and step file names did not follow a consistent pattern. To make it easier to automate in the future, things were renamed in the following ways:
      
      StepId: camel case, prefix with the short name that we usually use to refer to the tutorial, e.g. name, music, chaseGame. Followed by a name for the step, e.g. nameAddSprite, nameAddBackdrop. When there are two of a step, add ‘2’ to the end e.g. nameAddSprite2
      
      file-naming: all step files should be in the steps directory. The name is the ‘kebab’ case of the stepId, followed by the language-code, then the file extension. For example the english version of the file for `nameAddSprite` would be `name-add-sprite.en.gif`, `chaseGameAddSprite2` would be `chase-game-add-sprite2.en.gif`
      686dbb52
    • chrisgarrity's avatar
      refactor image files · 26de4b2e
      chrisgarrity authored
      * thumbnails folder: thumbnail images for tutorials (multistep decks and videos). Images should not need translations (avoid text that would need translation in the image)
      * steps folder: gif images associated with tutorial steps. Images can be translated. English (default) images have the extension `.en.gif`, other language images should replace the `.en` with the corresponding locale.
      * renamed some of the steps files to be more consistent and a bit less redundant
      * removed a couple of files that were no longer referenced
      * revised webpack config to allow localized step files to be loaded from `/static` on www
      26de4b2e
  11. Feb 27, 2019
  12. Feb 25, 2019
  13. Feb 20, 2019
  14. Feb 16, 2019
  15. Feb 15, 2019
  16. Feb 14, 2019
  17. Feb 13, 2019
Loading