Commits · 0191f978dccd1d06903ab684377ce15549ac7c3e · David Goessmann / logging-scratch-gui

Nov 29, 2018
- changed comment text in alerts.js · 0af13c46
  Ben Wheeler authored 6 years ago
  
  0af13c46
- corrected jsdoc property name · 0ce9f3c4
  Ben Wheeler authored 6 years ago
  
  0ce9f3c4
- renamed SHOW_STANDARD_ALERT to SHOW_ALERT · 7fef8ed9
  Ben Wheeler authored 6 years ago
  
  7fef8ed9
- make alerts list filtering into a reducer selector · 1d44b10e
  Ben Wheeler authored 6 years ago
  
  1d44b10e
Nov 28, 2018

Add download and retry saving to saving error alert. · bd6c6599

Paul Kaplan authored 6 years ago

I do not like how the alert component is hyper specialized for two distinct use cases. It would be much better to refactor the alerts so that the alerter can just fill the alert with whatever they want. But I do not feel comfortable making that refactor because I know ben and evelyn have gone back and forth about these alerts.

bd6c6599

Nov 20, 2018
- Extension name fix. · 7bfaa04e
  Evelyn Eastmond authored 6 years ago
  
  7bfaa04e
- Adding localization to extension alerts. · 514ade25
  Evelyn Eastmond authored 6 years ago
  
  514ade25
- Fixing a prop type. · 8c69578c
  Evelyn Eastmond authored 6 years ago
  
  8c69578c
- Minor cleanup in alerts reducer. · 911adb8d
  Evelyn Eastmond authored 6 years ago
  
  911adb8d
- Removing extraneous message prop from alerts. · d79b7e0b
  Evelyn Eastmond authored 6 years ago
  
  d79b7e0b
Nov 15, 2018
- moved away from using thunk for async · 2b33066e
  Ben Wheeler authored 6 years ago
  
  2b33066e
- menu bar save messaging; self-dismissing alerts · 6152fb77
  Ben Wheeler authored 6 years ago
  
  6152fb77
- saving, creation errors use alerts; alerts css improvements · 2766c9a2
  Ben Wheeler authored 6 years ago
  
  2766c9a2
Nov 08, 2018
- added spinner icon to alerts · 90ac26e1
  Ben Wheeler authored 6 years ago
  
  90ac26e1
- clear matching alerts · 75ea0694
  Ben Wheeler authored 6 years ago
  
  75ea0694
- distinguish between auto saves and manual saves; clear previous alerts · f65eb817
  Ben Wheeler authored 6 years ago
  
  f65eb817
- made alert type called standard alerts; used for saving, creating · 8d0935ab
  Ben Wheeler authored 6 years ago
  
  made alert messages translation-ready updated project saver hoc default alerts to COLOR_ORANGE got tests working made neutral button color
  8d0935ab
Nov 02, 2018
- Made onReconnect not required, and added showReconnect boolean to optionally show reconnect button. · c0115c9c
  Evelyn Eastmond authored 6 years ago
  
  c0115c9c
- Adding extensionId to reconnect button, other cleanup. · f6ae2fd1
  Evelyn Eastmond authored 6 years ago
  
  f6ae2fd1
Oct 03, 2018
- Cleanup for react container/component pattern for alerts/alert containers and components. · 3a77388f
  Evelyn Eastmond authored 6 years ago
  
  3a77388f
Sep 24, 2018
- Adding jsdocs to the alert reducers. · 0265a864
  Evelyn Eastmond authored 6 years ago
  
  0265a864
- Moved alert icon check/display up to reducer, and also moved alert message construction to reducer. · d5eb947c
  Evelyn Eastmond authored 6 years ago
  
  d5eb947c
- Adding Alerts container to handle click, and pass key prop appropriately. · bdaa407f
  Evelyn Eastmond authored 6 years ago
  
  bdaa407f
- Customizing alerts for extensions. · abe33f10
  Evelyn Eastmond authored 6 years ago
  
  abe33f10
- Adding a custom extension image to alerts, etc. · 5e6db18d
  Evelyn Eastmond authored 6 years ago
  
  5e6db18d
- Beginning multiple alerts component. · 0e5fa0b3
  Evelyn Eastmond authored 6 years ago
  
  0e5fa0b3
Sep 19, 2018
- Changes based on PR feedback from rschamp. · cdb87608
  Evelyn Eastmond authored 6 years ago
  
  cdb87608
- Adding reconnect button, fixing CSS. · 820335c2
  Evelyn Eastmond authored 6 years ago
  
  820335c2
- Adding dismissal of alert. · 8d9a6f30
  Evelyn Eastmond authored 6 years ago
  
  8d9a6f30
- Passing custom alert messages. · 3330ed75
  Evelyn Eastmond authored 6 years ago
  
  3330ed75
- Changing alert to 'peripheral error'. · 0366e351
  Evelyn Eastmond authored 6 years ago
  
  0366e351
- Renaming viewAlert to showAlert. · 1822e82a
  Evelyn Eastmond authored 6 years ago
  
  1822e82a
- Connecting a view alerts reducer. · 25b81d80
  Evelyn Eastmond authored 6 years ago
  
  25b81d80
- Beginning to add alerts component. · d4b9f52a
  Evelyn Eastmond authored 6 years ago
  
  d4b9f52a

Admin message