Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
L
logging-scratch-gui
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
David Goessmann
logging-scratch-gui
Commits
5b6ee3a6
Commit
5b6ee3a6
authored
6 years ago
by
apple502j
Committed by
chrisgarrity
6 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Translate 2 strings on list monitor (#3259)
* Translate "(empty)" and "length {value.length}" * Use FormattedMessage
parent
2e299d3f
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/components/monitor/list-monitor-scroller.jsx
+6
-1
6 additions, 1 deletion
src/components/monitor/list-monitor-scroller.jsx
src/components/monitor/list-monitor.jsx
+9
-1
9 additions, 1 deletion
src/components/monitor/list-monitor.jsx
with
15 additions
and
2 deletions
src/components/monitor/list-monitor-scroller.jsx
+
6
−
1
View file @
5b6ee3a6
...
...
@@ -2,6 +2,7 @@ import React from 'react';
import
PropTypes
from
'
prop-types
'
;
import
classNames
from
'
classnames
'
;
import
bindAll
from
'
lodash.bindall
'
;
import
{
FormattedMessage
}
from
'
react-intl
'
;
import
styles
from
'
./monitor.css
'
;
import
{
List
}
from
'
react-virtualized
'
;
...
...
@@ -21,7 +22,11 @@ class ListMonitorScroller extends React.Component {
noRowsRenderer
()
{
return
(
<
div
className
=
{
classNames
(
styles
.
listRow
,
styles
.
listEmpty
)
}
>
{
'
(empty)
'
/* TODO waiting for design before translation */
}
<
FormattedMessage
defaultMessage
=
"(empty)"
description
=
"Text shown on a list monitor when a list is empty"
id
=
"gui.monitor.listMonitor.empty"
/>
</
div
>
);
}
...
...
This diff is collapsed.
Click to expand it.
src/components/monitor/list-monitor.jsx
+
9
−
1
View file @
5b6ee3a6
import
React
from
'
react
'
;
import
PropTypes
from
'
prop-types
'
;
import
classNames
from
'
classnames
'
;
import
{
FormattedMessage
}
from
'
react-intl
'
;
import
styles
from
'
./monitor.css
'
;
import
ListMonitorScroller
from
'
./list-monitor-scroller.jsx
'
;
...
...
@@ -32,7 +33,14 @@ const ListMonitor = ({draggable, label, width, height, value, onResizeMouseDown,
{
'
+
'
/* TODO waiting on asset */
}
</
div
>
<
div
className
=
{
styles
.
footerLength
}
>
{
`length
${
value
.
length
}
`
}
<
FormattedMessage
defaultMessage
=
"length {length}"
description
=
"Length label on list monitors. DO NOT translate {length} (with brackets)."
id
=
"gui.monitor.listMonitor.listLength"
values
=
{
{
length
:
value
.
length
}
}
/>
</
div
>
<
div
className
=
{
classNames
(
draggable
?
styles
.
resizeHandle
:
null
,
'
no-drag
'
)
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment