Skip to content
Snippets Groups Projects
Commit 506d82ff authored by Paul Kaplan's avatar Paul Kaplan
Browse files

Correctly specify react and react-dom as externals

Previously, the syntax was incorrect and was not doing anything.
Additionally, it was attempting to set them as externals in the playground
builds, which is incorrect, they need to be included in the playground build.
parent 1fc2e391
Branches
Tags
No related merge requests found
......@@ -27,10 +27,6 @@ const base = {
filename: '[name].js',
chunkFilename: 'chunks/[name].js'
},
externals: {
React: 'react',
ReactDOM: 'react-dom'
},
resolve: {
symlinks: false
},
......@@ -113,10 +109,6 @@ module.exports = [
path: path.resolve(__dirname, 'build'),
filename: '[name].js'
},
externals: {
React: 'react',
ReactDOM: 'react-dom'
},
module: {
rules: base.module.rules.concat([
{
......@@ -200,8 +192,8 @@ module.exports = [
publicPath: `${STATIC_PATH}/`
},
externals: {
React: 'react',
ReactDOM: 'react-dom'
'react': 'react',
'react-dom': 'react-dom'
},
module: {
rules: base.module.rules.concat([
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment