Skip to content
Snippets Groups Projects
Commit 47d4afa3 authored by Ray Schamp's avatar Ray Schamp
Browse files

Be more succinct with the open prop

parent 76171a8f
No related branches found
No related tags found
No related merge requests found
......@@ -8,35 +8,27 @@ const MenuComponent = ({
className = '',
children,
componentRef,
open = false,
place = 'right'
}) => {
if (open) {
return (
<ul
className={classNames(
styles.menu,
className,
{
[styles.open]: open,
[styles.left]: place === 'left',
[styles.right]: place === 'right'
}
)}
ref={componentRef}
>
{children}
</ul>
);
}
return null;
};
}) => (
<ul
className={classNames(
styles.menu,
className,
{
[styles.left]: place === 'left',
[styles.right]: place === 'right'
}
)}
ref={componentRef}
>
{children}
</ul>
);
MenuComponent.propTypes = {
children: PropTypes.node,
className: PropTypes.string,
componentRef: PropTypes.func,
open: PropTypes.bool,
place: PropTypes.oneOf(['left', 'right'])
};
......
......@@ -39,10 +39,10 @@ class Menu extends React.Component {
children,
...props
} = this.props;
if (!open) return null;
return (
<MenuComponent
componentRef={this.ref}
open={open}
{...props}
>
{children}
......@@ -53,8 +53,8 @@ class Menu extends React.Component {
Menu.propTypes = {
children: PropTypes.node,
onRequestClose: PropTypes.func,
open: PropTypes.bool
onRequestClose: PropTypes.func.isRequired,
open: PropTypes.bool.isRequired
};
export default Menu;
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment