Skip to content
Snippets Groups Projects
  • Paul Kaplan's avatar
    c75e2acf
    Remove the redux throttle for targets update. · c75e2acf
    Paul Kaplan authored
    This fixes the root cause of #2858, which is caused because we are rendering the sound editor based on the GUI editing target data, but retrieving the sound based on the vms editing target data. The throttle of the redux action was causing those to get out of sync while a project was running.
    
    The throttle is not needed because the vm runtime already batches those updates at 30 fps. The updates that come from top-level actions like switching sprites go out immediately.
    
    This is also a minor performance boost, because there was a few ms being spent in setting and checking timers that were not needed.
    c75e2acf
    History
    Remove the redux throttle for targets update.
    Paul Kaplan authored
    This fixes the root cause of #2858, which is caused because we are rendering the sound editor based on the GUI editing target data, but retrieving the sound based on the vms editing target data. The throttle of the redux action was causing those to get out of sync while a project was running.
    
    The throttle is not needed because the vm runtime already batches those updates at 30 fps. The updates that come from top-level actions like switching sprites go out immediately.
    
    This is also a minor performance boost, because there was a few ms being spent in setting and checking timers that were not needed.
Code owners