Skip to content
Snippets Groups Projects
  • Christopher Willis-Ford's avatar
    76cd737b
    don't pass isRtl to TargetPaneComponent · 76cd737b
    Christopher Willis-Ford authored
    Prior to this change, `TargetPane` passed `isRtl` to
    `TargetPaneComponent` which then passed it into a `div`, causing the
    warning below. Since `TargetPaneComponent` doesn't currently use `isRtl`
    so there's no need to pass it in. If `TargetPaneComponent` starts
    needing `isRtl` then we should adjust it to not pass that property to
    any DOM elements.
    
    The console warning in question is 57 lines long and starts with:
    
    Warning: React does not recognize the `isRtl` prop on a DOM element. If
    you intentionally want it to appear in the DOM as a custom attribute,
    spell it as lowercase `isrtl` instead. If you accidentally passed it
    from a parent component, remove it from the DOM element.
    76cd737b
    History
    don't pass isRtl to TargetPaneComponent
    Christopher Willis-Ford authored
    Prior to this change, `TargetPane` passed `isRtl` to
    `TargetPaneComponent` which then passed it into a `div`, causing the
    warning below. Since `TargetPaneComponent` doesn't currently use `isRtl`
    so there's no need to pass it in. If `TargetPaneComponent` starts
    needing `isRtl` then we should adjust it to not pass that property to
    any DOM elements.
    
    The console warning in question is 57 lines long and starts with:
    
    Warning: React does not recognize the `isRtl` prop on a DOM element. If
    you intentionally want it to appear in the DOM as a custom attribute,
    spell it as lowercase `isrtl` instead. If you accidentally passed it
    from a parent component, remove it from the DOM element.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.