From 194ed86674decebd67bae1b041e6705583e114f3 Mon Sep 17 00:00:00 2001 From: Georg Seibt <seibt@fim.uni-passau.de> Date: Thu, 20 Oct 2016 17:00:22 +0200 Subject: [PATCH] String equals may be faster than Repository equals, id should never be null and returning "null" doesn't seem useful... --- src/de/uni_passau/fim/seibt/gitwrapper/repo/Reference.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/de/uni_passau/fim/seibt/gitwrapper/repo/Reference.java b/src/de/uni_passau/fim/seibt/gitwrapper/repo/Reference.java index e75abed..ae967b1 100644 --- a/src/de/uni_passau/fim/seibt/gitwrapper/repo/Reference.java +++ b/src/de/uni_passau/fim/seibt/gitwrapper/repo/Reference.java @@ -124,16 +124,16 @@ public abstract class Reference { } Commit commit = (Commit) o; - return Objects.equals(repo, commit.repo) && Objects.equals(id, commit.id); + return Objects.equals(id, commit.id) && Objects.equals(repo, commit.repo); } @Override public final int hashCode() { - return Objects.hash(repo, id); + return Objects.hash(id, repo); } @Override public String toString() { - return String.valueOf(id); + return id; } } -- GitLab