From f8971ca13e07656d5d78b4afccf1ae6db535e286 Mon Sep 17 00:00:00 2001 From: Ben Wheeler <wheeler.benjamin@gmail.com> Date: Mon, 8 Oct 2018 12:41:33 -0400 Subject: [PATCH] added comments about compose function --- src/containers/gui.jsx | 3 +++ src/playground/player.jsx | 9 ++++++++- src/playground/render-gui.jsx | 4 ++++ 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/src/containers/gui.jsx b/src/containers/gui.jsx index a02609d7b..be68e3dd6 100644 --- a/src/containers/gui.jsx +++ b/src/containers/gui.jsx @@ -124,6 +124,9 @@ const ConnectedGUI = connect( mapDispatchToProps, )(GUI); +// note that redux's 'compose' function is just being used as a general utility to make +// the hierarchy of HOC constructor calls clearer here; it has nothing to do with redux's +// ability to compose reducers. const WrappedGui = compose( ErrorBoundaryHOC('Top Level App'), ProjectFetcherHOC, diff --git a/src/playground/player.jsx b/src/playground/player.jsx index 6fdd230ef..d47795c2e 100644 --- a/src/playground/player.jsx +++ b/src/playground/player.jsx @@ -50,7 +50,14 @@ const mapDispatchToProps = dispatch => ({ onSeeInside: () => dispatch(setPlayer(false)) }); -const ConnectedPlayer = connect(mapStateToProps, mapDispatchToProps)(Player); +const ConnectedPlayer = connect( + mapStateToProps, + mapDispatchToProps +)(Player); + +// note that redux's 'compose' function is just being used as a general utility to make +// the hierarchy of HOC constructor calls clearer here; it has nothing to do with redux's +// ability to compose reducers. const WrappedPlayer = compose( HashParserHOC, AppStateHOC, diff --git a/src/playground/render-gui.jsx b/src/playground/render-gui.jsx index 1bb4ead50..a7df02ca2 100644 --- a/src/playground/render-gui.jsx +++ b/src/playground/render-gui.jsx @@ -15,6 +15,10 @@ import ProjectMetaDataHOC from '../lib/project-metadata-hoc.jsx'; */ export default appTarget => { GUI.setAppElement(appTarget); + + // note that redux's 'compose' function is just being used as a general utility to make + // the hierarchy of HOC constructor calls clearer here; it has nothing to do with redux's + // ability to compose reducers. const WrappedGui = compose( AppStateHOC, HashParserHOC, // NOTE: IMPORTANT: ok that i've reordered this? -- GitLab