From f6e9a7dd23649835ccecf9a9ae27c8222bd829b9 Mon Sep 17 00:00:00 2001
From: Evelyn Eastmond <evhan55@gmail.com>
Date: Sun, 5 May 2019 14:09:28 -0400
Subject: [PATCH] Remove console log from reducer, fix variable and comments in
component.
---
src/components/cards/cards.jsx | 8 ++++----
src/reducers/cards.js | 2 --
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/components/cards/cards.jsx b/src/components/cards/cards.jsx
index 017967512..8eacc5b44 100644
--- a/src/components/cards/cards.jsx
+++ b/src/components/cards/cards.jsx
@@ -266,9 +266,9 @@ const Cards = props => {
// Tutorial cards need to calculate their own dragging bounds
// to allow for dragging the cards off the left, right and bottom
- // edges of the workspace, used in the custom overlay 'card-container-overlay'
- const cardHorizontalOffset = 400; // 80% of approx. card width
- const cardVerticalOffset = 256; // 80% of approx. card height
+ // edges of the workspace.
+ const cardHorizontalOffset = 400; // ~80% of card width
+ const cardVerticalOffset = expanded ? 257 : 0; // ~80% of card height, if expanded
const menuBarHeight = 48; // TODO: get pre-calculated from elsewhere?
if (x === 0 && y === 0) {
@@ -285,7 +285,7 @@ const Cards = props => {
const steps = content[activeDeckId].steps;
return (
- // Use a custom overlay to act as the bounding parent for the draggable
+ // Custom overlay to act as the bounding parent for the draggable, using values from above
<div
className={styles.cardContainerOverlay}
style={{
diff --git a/src/reducers/cards.js b/src/reducers/cards.js
index 4e5c4af11..c54161f4c 100644
--- a/src/reducers/cards.js
+++ b/src/reducers/cards.js
@@ -31,8 +31,6 @@ const reducer = function (state, action) {
visible: false
});
case SHRINK_EXPAND_CARDS:
- // Set new position here based on bounds
- console.log('TODO: set new position based on bounds');
return Object.assign({}, state, {
expanded: !state.expanded
});
--
GitLab