From ee72f23f7b5dd20e3db091e4ea107660d4b1759f Mon Sep 17 00:00:00 2001 From: Tim Mickel <tim.mickel@gmail.com> Date: Thu, 20 Oct 2016 13:26:09 -0400 Subject: [PATCH] Idiomatic "map" --- src/components/library.js | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/src/components/library.js b/src/components/library.js index 43923dc40..39dec362a 100644 --- a/src/components/library.js +++ b/src/components/library.js @@ -17,22 +17,20 @@ class LibraryComponent extends React.Component { this.setState({selectedItem: id}); } render () { - let gridItems = []; let itemId = 0; - for (let dataItem of this.props.data) { + let gridItems = this.props.data.map(function (dataItem) { + let id = itemId; + itemId++; const scratchURL = (dataItem.md5) ? 'https://cdn.assets.scratch.mit.edu/internalapi/asset/' + dataItem.md5 + '/get/' : dataItem.rawURL; - gridItems.push( - <LibraryItem - name={dataItem.name} - iconURL={scratchURL} - key={'item_' + itemId} - selected={this.state.selectedItem == itemId} - onSelect={this.onSelect.bind(this)} - id={itemId} /> - ); - itemId++; - } + return <LibraryItem + name={dataItem.name} + iconURL={scratchURL} + key={'item_' + itemId} + selected={this.state.selectedItem == itemId} + onSelect={this.onSelect.bind(this)} + id={id} />; + }); const scrollGridStyle = { overflow: 'scroll', -- GitLab