From c36e618bebb16e87eeca23859f908ce576ab8a0b Mon Sep 17 00:00:00 2001
From: Tina Quach <quacht@mit.edu>
Date: Fri, 1 Dec 2017 11:33:30 -0500
Subject: [PATCH] use tabindex 0 to standardize tab order
---
src/components/sprite-info/sprite-info.jsx | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/components/sprite-info/sprite-info.jsx b/src/components/sprite-info/sprite-info.jsx
index 2bf5fe7ba..d67a8dc8e 100644
--- a/src/components/sprite-info/sprite-info.jsx
+++ b/src/components/sprite-info/sprite-info.jsx
@@ -42,7 +42,7 @@ class SpriteInfo extends React.Component {
<BufferedInput
disabled={this.props.disabled}
placeholder="Name"
- tabIndex="1"
+ tabIndex="0"
type="text"
value={this.props.disabled ? '' : this.props.name}
onSubmit={this.props.onChangeName}
@@ -65,7 +65,7 @@ class SpriteInfo extends React.Component {
small
disabled={this.props.disabled}
placeholder="x"
- tabIndex="2"
+ tabIndex="0"
type="text"
value={this.props.disabled ? '' : this.props.x}
onSubmit={this.props.onChangeX}
@@ -88,7 +88,7 @@ class SpriteInfo extends React.Component {
small
disabled={this.props.disabled}
placeholder="y"
- tabIndex="3"
+ tabIndex="0"
type="text"
value={this.props.disabled ? '' : this.props.y}
onSubmit={this.props.onChangeY}
@@ -116,7 +116,7 @@ class SpriteInfo extends React.Component {
[styles.isDisabled]: this.props.disabled
}
)}
- tabIndex="4"
+ tabIndex="0"
onClick={this.props.onClickVisible}
onKeyPress={this.props.onPressVisible}
>
@@ -135,7 +135,7 @@ class SpriteInfo extends React.Component {
[styles.isDisabled]: this.props.disabled
}
)}
- tabIndex="5"
+ tabIndex="0"
onClick={this.props.onClickNotVisible}
onKeyPress={this.props.onPressNotVisible}
>
@@ -155,7 +155,7 @@ class SpriteInfo extends React.Component {
small
disabled={this.props.disabled}
label="Direction"
- tabIndex="6"
+ tabIndex="0"
type="text"
value={this.props.disabled ? '' : this.props.direction}
onSubmit={this.props.onChangeDirection}
@@ -170,8 +170,8 @@ class SpriteInfo extends React.Component {
<select
className={classNames(styles.selectForm, styles.rotationSelect)}
disabled={this.props.disabled}
+ tabIndex="0"
value={this.props.rotationStyle}
- tabIndex="7"
onChange={this.props.onChangeRotationStyle}
>
{ROTATION_STYLES.map(style => (
--
GitLab