From 86a8dd36216ba58f175335ce5c34a155d4a8b815 Mon Sep 17 00:00:00 2001
From: chrisgarrity <chrisg@media.mit.edu>
Date: Thu, 16 Aug 2018 17:12:53 -0400
Subject: [PATCH] Fixes for firefox on Windows
---
src/components/language-selector/language-selector.css | 10 +++++++---
src/components/menu-bar/menu-bar.css | 2 +-
src/components/menu-bar/menu-bar.jsx | 6 ++----
3 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/src/components/language-selector/language-selector.css b/src/components/language-selector/language-selector.css
index df53ddbd8..219896103 100644
--- a/src/components/language-selector/language-selector.css
+++ b/src/components/language-selector/language-selector.css
@@ -7,7 +7,7 @@
/* Position the language select over the language icon, and make it transparent */
.language-select {
- position: relative;
+ position: absolute;
width: 3rem;
height: 3rem;
opacity: 0;
@@ -17,11 +17,15 @@
}
[dir="ltr"] .language-select {
- right: 40px;
+ right: 0;
}
[dir="rtl"] .language-select {
- left: 40px;
+ left: 0;
+}
+
+.language-select option {
+ opacity: 1;
}
.language-select:focus {
diff --git a/src/components/menu-bar/menu-bar.css b/src/components/menu-bar/menu-bar.css
index 46e63cc53..74cbd5f22 100644
--- a/src/components/menu-bar/menu-bar.css
+++ b/src/components/menu-bar/menu-bar.css
@@ -49,7 +49,7 @@
}
.language-caret {
- vertical-align: text-top;
+ margin-bottom: .625rem;
}
.language-menu {
diff --git a/src/components/menu-bar/menu-bar.jsx b/src/components/menu-bar/menu-bar.jsx
index 1d28ad6ac..98bf19bc5 100644
--- a/src/components/menu-bar/menu-bar.jsx
+++ b/src/components/menu-bar/menu-bar.jsx
@@ -167,9 +167,7 @@ class MenuBar extends React.Component {
<div
className={classNames(styles.menuBarItem, styles.hoverable, styles.languageMenu)}
>
- <div
- aria-label={this.props.intl.formatMessage(ariaMessages.language)}
- >
+ <div>
<img
className={styles.languageIcon}
src={languageIcon}
@@ -179,7 +177,7 @@ class MenuBar extends React.Component {
src={dropdownCaret}
/>
</div>
- <LanguageSelector />
+ <LanguageSelector aria-label={this.props.intl.formatMessage(ariaMessages.language)} />
</div>
<div
className={classNames(styles.menuBarItem, styles.hoverable, {
--
GitLab