From 76f203d2a952a7d61593cad3c3fba827ca2fd5d5 Mon Sep 17 00:00:00 2001
From: Karishma Chadha <kchadha@media.mit.edu>
Date: Fri, 16 Nov 2018 20:06:28 -0500
Subject: [PATCH] Fix monitor label for day of week block. Add unit tests for
opcode-labels util.
---
src/lib/opcode-labels.js | 4 ++--
test/unit/util/opcode-labels.test.js | 15 +++++++++++++++
2 files changed, 17 insertions(+), 2 deletions(-)
create mode 100644 test/unit/util/opcode-labels.test.js
diff --git a/src/lib/opcode-labels.js b/src/lib/opcode-labels.js
index a916fba93..dde8636be 100644
--- a/src/lib/opcode-labels.js
+++ b/src/lib/opcode-labels.js
@@ -89,8 +89,8 @@ const messages = defineMessages({
id: 'gui.opcodeLabels.date'
},
sensing_current_dayofweek: {
- defaultMessage: 'dayofweek',
- description: 'Label for the current dayofweek monitor when shown on the stage',
+ defaultMessage: 'day of week',
+ description: 'Label for the current day of week monitor when shown on the stage',
id: 'gui.opcodeLabels.dayofweek'
},
sensing_current_hour: {
diff --git a/test/unit/util/opcode-labels.test.js b/test/unit/util/opcode-labels.test.js
new file mode 100644
index 000000000..78bdfeaa7
--- /dev/null
+++ b/test/unit/util/opcode-labels.test.js
@@ -0,0 +1,15 @@
+import opcodeLabels from '../../../src/lib/opcode-labels';
+
+describe('Opcode Labels', () => {
+ test('day of week label', () => {
+ const labelFun = opcodeLabels.getLabel('sensing_current').labelFn;
+ expect(labelFun({CURRENTMENU: 'dayofweek'})).toBe('day of week');
+ expect(labelFun({CURRENTMENU: 'DAYOFWEEK'})).toBe('day of week');
+ });
+
+ test('unspecified opcodes default to extension category and opcode as label', () => {
+ const labelInfo = opcodeLabels.getLabel('music_getTempo');
+ expect(labelInfo.label).toBe('music_getTempo');
+ expect(labelInfo.category).toBe('extension');
+ });
+});
--
GitLab