From 76cd737bec27fac29afc276800743dd61b22e1cb Mon Sep 17 00:00:00 2001
From: Christopher Willis-Ford <7019101+cwillisf@users.noreply.github.com>
Date: Wed, 17 Feb 2021 15:00:10 -0800
Subject: [PATCH] don't pass isRtl to TargetPaneComponent
Prior to this change, `TargetPane` passed `isRtl` to
`TargetPaneComponent` which then passed it into a `div`, causing the
warning below. Since `TargetPaneComponent` doesn't currently use `isRtl`
so there's no need to pass it in. If `TargetPaneComponent` starts
needing `isRtl` then we should adjust it to not pass that property to
any DOM elements.
The console warning in question is 57 lines long and starts with:
Warning: React does not recognize the `isRtl` prop on a DOM element. If
you intentionally want it to appear in the DOM as a custom attribute,
spell it as lowercase `isrtl` instead. If you accidentally passed it
from a parent component, remove it from the DOM element.
---
src/containers/target-pane.jsx | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/containers/target-pane.jsx b/src/containers/target-pane.jsx
index 8e6633db8..010cf12dd 100644
--- a/src/containers/target-pane.jsx
+++ b/src/containers/target-pane.jsx
@@ -237,6 +237,7 @@ class TargetPane extends React.Component {
/* eslint-disable no-unused-vars */
const {
dispatchUpdateRestore,
+ isRtl,
onActivateTab,
onCloseImporting,
onHighlightTarget,
--
GitLab