From 4e47cc875ae49c3aed46ccb1160f4cae8aa4c33a Mon Sep 17 00:00:00 2001
From: Chris Garrity <chrisg@media.mit.edu>
Date: Mon, 22 Jul 2019 10:36:21 -0400
Subject: [PATCH] Cleanup
* removed commented out cruft
* added tabIndex prop to delete button (with default=0)
* the last change also required a change to the sprite selector test snapshot
---
src/components/delete-button/delete-button.css | 5 -----
src/components/delete-button/delete-button.jsx | 9 +++++++--
.../__snapshots__/sprite-selector-item.test.jsx.snap | 4 ++--
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/components/delete-button/delete-button.css b/src/components/delete-button/delete-button.css
index be093ac5c..3224e23b9 100644
--- a/src/components/delete-button/delete-button.css
+++ b/src/components/delete-button/delete-button.css
@@ -17,11 +17,6 @@
}
-/* .delete-button.large:hover {
- transform: scale(1.1, 1.1);
- box-shadow: 0 0 0 4px $ui-black-transparent;
-} */
-
.delete-button-visible {
display: flex;
align-items: center;
diff --git a/src/components/delete-button/delete-button.jsx b/src/components/delete-button/delete-button.jsx
index 9e6370160..6e84fb983 100644
--- a/src/components/delete-button/delete-button.jsx
+++ b/src/components/delete-button/delete-button.jsx
@@ -13,7 +13,7 @@ const DeleteButton = props => (
props.className
)}
role="button"
- tabIndex="0"
+ tabIndex={props.tabIndex}
onClick={props.onClick}
>
<div className={styles.deleteButtonVisible}>
@@ -28,7 +28,12 @@ const DeleteButton = props => (
DeleteButton.propTypes = {
className: PropTypes.string,
- onClick: PropTypes.func.isRequired
+ onClick: PropTypes.func.isRequired,
+ tabIndex: PropTypes.number
+};
+
+DeleteButton.defaultProps = {
+ tabIndex: 0
};
export default DeleteButton;
diff --git a/test/unit/components/__snapshots__/sprite-selector-item.test.jsx.snap b/test/unit/components/__snapshots__/sprite-selector-item.test.jsx.snap
index 34c970f1e..f7f19434a 100644
--- a/test/unit/components/__snapshots__/sprite-selector-item.test.jsx.snap
+++ b/test/unit/components/__snapshots__/sprite-selector-item.test.jsx.snap
@@ -50,7 +50,7 @@ exports[`SpriteSelectorItemComponent matches snapshot when given a number and de
className=""
onClick={[Function]}
role="button"
- tabIndex="0"
+ tabIndex={0}
>
<div
className={undefined}
@@ -134,7 +134,7 @@ exports[`SpriteSelectorItemComponent matches snapshot when selected 1`] = `
className=""
onClick={[Function]}
role="button"
- tabIndex="0"
+ tabIndex={0}
>
<div
className={undefined}
--
GitLab