From 4c8d76b061cff622ad73d4ca9bd4c9b536a6dee4 Mon Sep 17 00:00:00 2001
From: Ray Schamp <ray@scratch.mit.edu>
Date: Thu, 12 Apr 2018 17:26:12 -0400
Subject: [PATCH] Match edit clickability to file
There's a subtle difference in behavior between mouseup and click. Using mouseup allows you to close the menu by clicking its opener item.
---
src/components/menu-bar/menu-bar.jsx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/components/menu-bar/menu-bar.jsx b/src/components/menu-bar/menu-bar.jsx
index e3d1961f5..82cd319f5 100644
--- a/src/components/menu-bar/menu-bar.jsx
+++ b/src/components/menu-bar/menu-bar.jsx
@@ -162,7 +162,7 @@ const MenuBar = props => (
className={classNames(styles.menuBarItem, styles.hoverable, {
[styles.active]: props.editMenuOpen
})}
- onClick={props.onClickEdit}
+ onMouseUp={props.onClickEdit}
>
<div className={classNames(styles.editMenu)}>Edit</div>
<MenuBarMenu
--
GitLab