diff --git a/src/reducers/project-state.js b/src/reducers/project-state.js index a26d7c97184cf4b93f2f1b3c7c4d50a56353454a..91e51bbe48e6b8fa1c0cb1b254cbce7350f4a246 100644 --- a/src/reducers/project-state.js +++ b/src/reducers/project-state.js @@ -17,7 +17,7 @@ const START_AUTO_UPDATING = 'scratch-gui/project-state/START_AUTO_UPDATING'; const START_CREATING_NEW = 'scratch-gui/project-state/START_CREATING_NEW'; const START_ERROR = 'scratch-gui/project-state/START_ERROR'; const START_FETCHING_NEW = 'scratch-gui/project-state/START_FETCHING_NEW'; -const START_LOADING_VM_FILE_UPLOAD = 'scratch-gui/project-state/START_LOADING_VM_FILE_UPLOAD'; +const START_LOADING_VM_FILE_UPLOAD = 'scratch-gui/project-state/START_LOADING_FILE_UPLOAD'; const START_MANUAL_UPDATING = 'scratch-gui/project-state/START_MANUAL_UPDATING'; const START_REMIXING = 'scratch-gui/project-state/START_REMIXING'; const START_UPDATING_BEFORE_CREATING_COPY = 'scratch-gui/project-state/START_UPDATING_BEFORE_CREATING_COPY'; @@ -435,21 +435,10 @@ const onLoadedProject = (loadingState, canSave, success) => { default: return; } - } else { - switch (loadingState) { - case LoadingState.LOADING_VM_WITH_ID: - case LoadingState.LOADING_VM_FILE_UPLOAD: - return { - type: RETURN_TO_SHOWING - }; - case LoadingState.LOADING_VM_NEW_DEFAULT: - return { - type: START_ERROR - }; - default: - return; - } } + return { + type: RETURN_TO_SHOWING + }; }; const doneUpdatingProject = loadingState => { diff --git a/test/unit/reducers/project-state-reducer.test.js b/test/unit/reducers/project-state-reducer.test.js index 6938085a3456da6c8c74d5646d32e6976f5951f9..2683c5beec159d4a08a86b003f15905071b82648 100644 --- a/test/unit/reducers/project-state-reducer.test.js +++ b/test/unit/reducers/project-state-reducer.test.js @@ -92,49 +92,16 @@ test('onFetchedProjectData new loads project data into vm', () => { expect(resultState.projectData).toBe('1010101'); }); -// onLoadedProject: LOADING_VM_WITH_ID - -test('onLoadedProject (LOADING_VM_WITH_ID, true, true) shows with id', () => { - const initialState = { - loadingState: LoadingState.LOADING_VM_WITH_ID - }; - const action = onLoadedProject(initialState.loadingState, true, true); - const resultState = projectStateReducer(initialState, action); - expect(resultState.loadingState).toBe(LoadingState.SHOWING_WITH_ID); -}); - -test('onLoadedProject (LOADING_VM_WITH_ID, false, true) shows with id', () => { - const initialState = { - loadingState: LoadingState.LOADING_VM_WITH_ID - }; - const action = onLoadedProject(initialState.loadingState, true, true); - const resultState = projectStateReducer(initialState, action); - expect(resultState.loadingState).toBe(LoadingState.SHOWING_WITH_ID); -}); - -test('onLoadedProject (LOADING_VM_WITH_ID, false, false), with project id, shows with id', () => { +test('onLoadedProject upload, with canSave false, shows without id', () => { const initialState = { - loadingState: LoadingState.LOADING_VM_WITH_ID, - projectId: '12345' - }; - const action = onLoadedProject(initialState.loadingState, false, false); - const resultState = projectStateReducer(initialState, action); - expect(resultState.loadingState).toBe(LoadingState.SHOWING_WITH_ID); -}); - -test('onLoadedProject (LOADING_VM_WITH_ID, false, false), with no project id, shows without id', () => { - const initialState = { - loadingState: LoadingState.LOADING_VM_WITH_ID, - projectId: null + loadingState: LoadingState.LOADING_VM_FILE_UPLOAD }; - const action = onLoadedProject(initialState.loadingState, false, false); + const action = onLoadedProject(initialState.loadingState, false, true); const resultState = projectStateReducer(initialState, action); expect(resultState.loadingState).toBe(LoadingState.SHOWING_WITHOUT_ID); }); -// onLoadedProject: LOADING_VM_FILE_UPLOAD - -test('onLoadedProject(LOADING_VM_FILE_UPLOAD, true, true) prepares to save', () => { +test('onLoadedProject upload, with canSave true, prepares to save', () => { const initialState = { loadingState: LoadingState.LOADING_VM_FILE_UPLOAD }; @@ -143,38 +110,25 @@ test('onLoadedProject(LOADING_VM_FILE_UPLOAD, true, true) prepares to save', () expect(resultState.loadingState).toBe(LoadingState.AUTO_UPDATING); }); -test('onLoadedProject (LOADING_VM_FILE_UPLOAD, false, true) shows without id', () => { +test('onLoadedProject with id shows with id', () => { const initialState = { - loadingState: LoadingState.LOADING_VM_FILE_UPLOAD - }; - const action = onLoadedProject(initialState.loadingState, false, true); - const resultState = projectStateReducer(initialState, action); - expect(resultState.loadingState).toBe(LoadingState.SHOWING_WITHOUT_ID); -}); - -test('onLoadedProject (LOADING_VM_FILE_UPLOAD, false, false), with project id, shows with id', () => { - const initialState = { - loadingState: LoadingState.LOADING_VM_FILE_UPLOAD, - projectId: '12345' + loadingState: LoadingState.LOADING_VM_WITH_ID }; - const action = onLoadedProject(initialState.loadingState, false, false); + const action = onLoadedProject(initialState.loadingState, true, true); const resultState = projectStateReducer(initialState, action); expect(resultState.loadingState).toBe(LoadingState.SHOWING_WITH_ID); }); -test('onLoadedProject (LOADING_VM_FILE_UPLOAD, false, false), with no project id, shows without id', () => { +test('onLoadedProject new shows without id', () => { const initialState = { - loadingState: LoadingState.LOADING_VM_FILE_UPLOAD, - projectId: null + loadingState: LoadingState.LOADING_VM_NEW_DEFAULT }; - const action = onLoadedProject(initialState.loadingState, false, false); + const action = onLoadedProject(initialState.loadingState, false, true); const resultState = projectStateReducer(initialState, action); expect(resultState.loadingState).toBe(LoadingState.SHOWING_WITHOUT_ID); }); -// onLoadedProject: LOADING_VM_NEW_DEFAULT - -test('onLoadedProject (LOADING_VM_NEW_DEFAULT, true, true) shows without id', () => { +test('onLoadedProject new, to save shows without id', () => { const initialState = { loadingState: LoadingState.LOADING_VM_NEW_DEFAULT }; @@ -183,26 +137,26 @@ test('onLoadedProject (LOADING_VM_NEW_DEFAULT, true, true) shows without id', () expect(resultState.loadingState).toBe(LoadingState.SHOWING_WITHOUT_ID); }); -test('onLoadedProject (LOADING_VM_NEW_DEFAULT, false, true) shows without id', () => { +test('onLoadedProject with success false, no project id, shows without id', () => { const initialState = { - loadingState: LoadingState.LOADING_VM_NEW_DEFAULT + loadingState: LoadingState.LOADING_VM_WITH_ID, + projectId: null }; - const action = onLoadedProject(initialState.loadingState, false, true); + const action = onLoadedProject(initialState.loadingState, false, false); const resultState = projectStateReducer(initialState, action); expect(resultState.loadingState).toBe(LoadingState.SHOWING_WITHOUT_ID); }); -test('onLoadedProject (LOADING_VM_NEW_DEFAULT, false, false) shows error', () => { +test('onLoadedProject with success false, valid project id, shows with id', () => { const initialState = { - loadingState: LoadingState.LOADING_VM_NEW_DEFAULT + loadingState: LoadingState.LOADING_VM_WITH_ID, + projectId: '12345' }; const action = onLoadedProject(initialState.loadingState, false, false); const resultState = projectStateReducer(initialState, action); - expect(resultState.loadingState).toBe(LoadingState.ERROR); + expect(resultState.loadingState).toBe(LoadingState.SHOWING_WITH_ID); }); -// doneUpdatingProject - test('doneUpdatingProject with id shows with id', () => { const initialState = { loadingState: LoadingState.MANUAL_UPDATING diff --git a/test/unit/util/project-saver-hoc.test.jsx b/test/unit/util/project-saver-hoc.test.jsx index f5ac7b680e669c758c6af021643be10fc4d35692..0ec3190bf773fdf74aa6cc39c671b27e0df32beb 100644 --- a/test/unit/util/project-saver-hoc.test.jsx +++ b/test/unit/util/project-saver-hoc.test.jsx @@ -56,7 +56,7 @@ describe('projectSaverHOC', () => { expect(mockedUpdateProject).toHaveBeenCalled(); }); - test('if canSave is already true and we show a project with an id, project will NOT be saved', () => { + test('if canSave is alreatdy true and we show a project with an id, project will NOT be saved', () => { const mockedSaveProject = jest.fn(); const Component = () => <div />; const WrappedComponent = projectSaverHOC(Component);