From 2429f63e028a29235e4c0166d89ea357d59c1a5e Mon Sep 17 00:00:00 2001
From: Paul Kaplan <pkaplan@media.mit.edu>
Date: Thu, 12 Sep 2019 12:12:01 -0400
Subject: [PATCH] Emit projectDidSave for server saves, not just file exports
---
src/lib/project-saver-hoc.jsx | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/src/lib/project-saver-hoc.jsx b/src/lib/project-saver-hoc.jsx
index dc3ee65cb..3898d08d6 100644
--- a/src/lib/project-saver-hoc.jsx
+++ b/src/lib/project-saver-hoc.jsx
@@ -251,6 +251,7 @@ const ProjectSaverHOC = function (WrappedComponent) {
if (id && this.props.onUpdateProjectThumbnail) {
this.storeProjectThumbnail(id);
}
+ this.reportTelemetryEvent('projectDidSave');
return response;
})
.catch(err => {
@@ -291,9 +292,15 @@ const ProjectSaverHOC = function (WrappedComponent) {
*/
// TODO make a telemetry HOC and move this stuff there
reportTelemetryEvent (event) {
- if (this.props.onProjectTelemetryEvent) {
- const metadata = collectMetadata(this.props.vm, this.props.reduxProjectTitle, this.props.locale);
- this.props.onProjectTelemetryEvent(event, metadata);
+ try {
+ if (this.props.onProjectTelemetryEvent) {
+ const metadata = collectMetadata(this.props.vm, this.props.reduxProjectTitle, this.props.locale);
+ this.props.onProjectTelemetryEvent(event, metadata);
+ }
+ } catch (e) {
+ log.error('Telemetry error', event, e);
+ // This is intentionally fire/forget because a failure
+ // to report telemetry should not block saving
}
}
--
GitLab