From 10c51fa4c1d85de2887f5a59f1e40f0d414617cf Mon Sep 17 00:00:00 2001
From: Paul Kaplan <pkaplan@media.mit.edu>
Date: Thu, 1 Nov 2018 10:26:02 -0400
Subject: [PATCH] Only null out asset drag if you were previously dragging
This was causing a re-render for anything using the `drop-area-hoc`
---
src/containers/sprite-selector-item.jsx | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/src/containers/sprite-selector-item.jsx b/src/containers/sprite-selector-item.jsx
index 7a1100d0b..c448df486 100644
--- a/src/containers/sprite-selector-item.jsx
+++ b/src/containers/sprite-selector-item.jsx
@@ -55,13 +55,15 @@ class SpriteSelectorItem extends React.Component {
window.removeEventListener('mousemove', this.handleMouseMove);
window.removeEventListener('touchend', this.handleMouseUp);
window.removeEventListener('touchmove', this.handleMouseMove);
- this.props.onDrag({
- img: null,
- currentOffset: null,
- dragging: false,
- dragType: null,
- index: null
- });
+ if (this.props.dragging) {
+ this.props.onDrag({
+ img: null,
+ currentOffset: null,
+ dragging: false,
+ dragType: null,
+ index: null
+ });
+ }
setTimeout(() => {
this.noClick = false;
});
@@ -156,6 +158,7 @@ SpriteSelectorItem.propTypes = {
body: PropTypes.string
}),
dragType: PropTypes.string,
+ dragging: PropTypes.bool,
id: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
index: PropTypes.number,
name: PropTypes.string,
--
GitLab